Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1267786
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() |
| Date | 2015-11-12 11:20 +0100 |
| Message-ID | <qtX91-7C4-19@gated-at.bofh.it> (permalink) |
| References | <qtMGB-Q4-11@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
Geert Uytterhoeven <geert@linux-m68k.org> wrote: > - int ret; > + int ret = 0; This isn't quite the right solution. The uninitialised error path needs to set -ENOBUFS. Unfortunately, my compiler doesn't show a warning:-/ David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 00:10 +0100
Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() David Howells <dhowells@redhat.com> - 2015-11-12 11:20 +0100
Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 11:30 +0100
Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() David Howells <dhowells@redhat.com> - 2015-11-12 11:50 +0100
Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 11:50 +0100
csiph-web