Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267792

Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()

Show all headers | View raw

Hi David,

On Thu, Nov 12, 2015 at 11:15 AM, David Howells <dhowells@redhat.com> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
>> -     int ret;
>> +     int ret = 0;
>
> This isn't quite the right solution.  The uninitialised error path needs to
> set -ENOBUFS.

That's what your commit 102f4d900c9c8f5e ("FS-Cache: Handle a write to the
page immediately beyond the EOF marker") does, and is also in its commit
description:

    Whilst we're at it, change the triggered assertion in CacheFiles to just
    return -ENOBUFS instead.

"ret" is used only to print the original error in a debug message.

> Unfortunately, my compiler doesn't show a warning:-/

Need old gcc (4.1.2 ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 00:10 +0100
  Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() David Howells <dhowells@redhat.com> - 2015-11-12 11:20 +0100
    Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 11:30 +0100
      Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() David Howells <dhowells@redhat.com> - 2015-11-12 11:50 +0100
        Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 11:50 +0100

csiph-web