Re: [PATCH] iio: Move IIO Dummy Driver out of staging

From	Daniel Baluta <daniel.baluta@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: Move IIO Dummy Driver out of staging
Date	2015-10-12 20:10 +0200
Message-ID	<qiPHQ-6Go-19@gated-at.bofh.it> (permalink)
References	<qhG3U-3xZ-19@gated-at.bofh.it> <qioRj-1b5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

<snip>

>> +static unsigned instances = 1;
>> +module_param(instances, uint, 0);

One concern about this. We will still create a default number of 'instances'
when using configuration via configfs?

I'm not sure we can remove this parameter once the module is moved
out of staging, since we break the ABI (?)

The rest looks good to me. I'm pretty sure that moving this out of staging
will make the module more visible and people will jump with enhancements.


thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iio: Move IIO Dummy Driver out of staging Daniel Baluta <daniel.baluta@intel.com> - 2015-10-12 20:10 +0200
  Re: [PATCH] iio: Move IIO Dummy Driver out of staging Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2015-10-13 07:50 +0200
    Re: [PATCH] iio: Move IIO Dummy Driver out of staging Lars-Peter Clausen <lars@metafoo.de> - 2015-10-13 13:00 +0200

csiph-web