Re: [PATCH] iio: Move IIO Dummy Driver out of staging

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Daniel Baluta <daniel.baluta@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: Move IIO Dummy Driver out of staging
Date	Mon, 12 Oct 2015 20:10:02 +0200
Message-ID	<qiPHQ-6Go-19@gated-at.bofh.it> (permalink)
References	<qhG3U-3xZ-19@gated-at.bofh.it> <qioRj-1b5-5@gated-at.bofh.it>
X-Original-To	Jonathan Cameron <jic23@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=jD0H2VNdMlFJCHk9MBOKDDAvFdkh5s9vZuC5js/CxKw=; b=Zl271HlqH5Q7toWkzOjQwpM752LFBHn/rWN10b7EQsRR8j0T57FijQxMEL+884d7ZE 7BRSV2iFaVaITaRQv5F7fCupAZs9cGGgyWIyEAGy+hCSaRAcXfL2WKlie+FH8Wbesawz T71FrF6wMNDY0NlpCB8csJnbMKUwCGXu/+9woI0/WXooeTSPcL5bY52hmFtDUQPVxl53 l2I8FOrN5QX7gr6ahevLXuCvzUZDeLWJZRQbPVUaowQpV20Pf6V+vRGLCgi3IdYTPHDQ hwzm7bac5nnd+bcrOpnyWu/BYdpf4jbMP3HKUBi5JOTwqxj1YDt1Wokv+yJh334UToIF 2zLg==
MIME-Version	1.0
X-Received	by 10.180.211.47 with SMTP id mz15mr15161703wic.93.1444672798052; Mon, 12 Oct 2015 10:59:58 -0700 (PDT)
X-Google-Sender-Auth	GNrGZmpuWHp5btM0KCdad5_i22s
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Cristina Opriceana <cristina.opriceana@gmail.com>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, Daniel Baluta <daniel.baluta@intel.com>, "octavian.purdila@intel.com" <octavian.purdila@intel.com>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald <pmeerw@pmeerw.net>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 12 Oct 2015 20:59:57 +0300
X-Original-Message-ID	<CAEnQRZDanmW90PifFcsTWLEzFNBUK25vDbcR9_iYVCJh3w4FYA@mail.gmail.com>
X-Original-References	<33d5396ef3a2c8ebe9a076a611bda60f9a1ae1e0.1444396827.git.cristina.opriceana@gmail.com> <561A63EE.5040206@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1244977

Show key headers only | View raw

<snip>

>> +static unsigned instances = 1;
>> +module_param(instances, uint, 0);

One concern about this. We will still create a default number of 'instances'
when using configuration via configfs?

I'm not sure we can remove this parameter once the module is moved
out of staging, since we break the ABI (?)

The rest looks good to me. I'm pretty sure that moving this out of staging
will make the module more visible and people will jump with enhancements.


thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iio: Move IIO Dummy Driver out of staging Daniel Baluta <daniel.baluta@intel.com> - 2015-10-12 20:10 +0200
  Re: [PATCH] iio: Move IIO Dummy Driver out of staging Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2015-10-13 07:50 +0200
    Re: [PATCH] iio: Move IIO Dummy Driver out of staging Lars-Peter Clausen <lars@metafoo.de> - 2015-10-13 13:00 +0200

csiph-web