Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244977 > unrolled thread

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] iio: Move IIO Dummy Driver out of staging Daniel Baluta <daniel.baluta@intel.com> - 2015-10-12 20:10 +0200
    Re: [PATCH] iio: Move IIO Dummy Driver out of staging Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2015-10-13 07:50 +0200
      Re: [PATCH] iio: Move IIO Dummy Driver out of staging Lars-Peter Clausen <lars@metafoo.de> - 2015-10-13 13:00 +0200

#1244977 — Re: [PATCH] iio: Move IIO Dummy Driver out of staging

<snip>

>> +static unsigned instances = 1;
>> +module_param(instances, uint, 0);

One concern about this. We will still create a default number of 'instances'
when using configuration via configfs?

I'm not sure we can remove this parameter once the module is moved
out of staging, since we break the ABI (?)

The rest looks good to me. I'm pretty sure that moving this out of staging
will make the module more visible and people will jump with enhancements.


thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245353

On 12 October 2015 18:59:57 BST, Daniel Baluta <daniel.baluta@intel.com> wrote:
><snip>
>
>>> +static unsigned instances = 1;
>>> +module_param(instances, uint, 0);
>
>One concern about this. We will still create a default number of
>'instances'
>when using configuration via configfs?
>
>I'm not sure we can remove this parameter once the module is moved
>out of staging, since we break the ABI (?)
I'm not that bothered about ABI breakage on this one. Not going to break anything
real after all!

>
>The rest looks good to me. I'm pretty sure that moving this out of
>staging
>will make the module more visible and people will jump with
>enhancements.
>
>
>thanks,
>Daniel
>--
>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245581

On 10/13/2015 07:44 AM, Jonathan Cameron wrote:
> 
> 
> On 12 October 2015 18:59:57 BST, Daniel Baluta <daniel.baluta@intel.com> wrote:
>> <snip>
>>
>>>> +static unsigned instances = 1;
>>>> +module_param(instances, uint, 0);
>>
>> One concern about this. We will still create a default number of
>> 'instances'
>> when using configuration via configfs?
>>
>> I'm not sure we can remove this parameter once the module is moved
>> out of staging, since we break the ABI (?)
> I'm not that bothered about ABI breakage on this one. Not going to break anything
> real after all!

ABI gets only broken if there is somebody to complain about it ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web