Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239134

Re: [PATCH v2] staging: iio: adc: fix comment block coding style issue

Show all headers | View raw

On 04/10/15 17:30, Hugo Camboulive wrote:
> This patch to ad7746.c makes the comment blocks end with a */
> on a separate line, and start with a /* on an empty line.
> 
> Signed-off-by: Hugo Camboulive <hugo.camboulive@gmail.com>
Thanks.

Applied to the togreg branch of iio.git - initially pushed out
as staging for the automated build testing to check it.
(obviously not really going to do much with this patch!)

Probably a good few more of these in the staging drivers if
you want to clear out a few more!

If not, take a look at the review I did of this driver the other
day for other bits that could do with cleaning up.
http://marc.info/?l=linux-iio&m=144277958123939&w=2

> ---
>  drivers/staging/iio/cdc/ad7746.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 10fa372..e8eab25 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -528,10 +528,11 @@ static int ad7746_write_raw(struct iio_dev *indio_dev,
>  			goto out;
>  		}
>  
> -		/* CAPDAC Scale = 21pF_typ / 127
> +		/*
> +		 * CAPDAC Scale = 21pF_typ / 127
>  		 * CIN Scale = 8.192pF / 2^24
>  		 * Offset Scale = CAPDAC Scale / CIN Scale = 338646
> -		 * */
> +		 */
>  
>  		val /= 338646;
>  
> @@ -600,7 +601,8 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
>  
>  		switch (chan->type) {
>  		case IIO_TEMP:
> -		/* temperature in milli degrees Celsius
> +		/*
> +		 * temperature in milli degrees Celsius
>  		 * T = ((*val / 2048) - 4096) * 1000
>  		 */
>  			*val = (*val * 125) / 256;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: iio: adc: fix comment block coding style issue Hugo Camboulive <hugo.camboulive@gmail.com> - 2015-10-03 18:40 +0200
  Re: [PATCH] staging: iio: adc: fix comment block coding style issue Lars-Peter Clausen <lars@metafoo.de> - 2015-10-04 14:00 +0200
    [PATCH v2] staging: iio: adc: fix comment block coding style issue Hugo Camboulive <hugo.camboulive@gmail.com> - 2015-10-04 16:40 +0200
      Re: [PATCH v2] staging: iio: adc: fix comment block coding style  issue Jonathan Cameron <jic23@kernel.org> - 2015-10-04 16:50 +0200

csiph-web