Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239133

Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure

Show all headers | View raw

On 04/10/15 12:04, Greg KH wrote:
> On Wed, Sep 30, 2015 at 01:36:31PM +0100, Srinivas Kandagatla wrote:
>> From: Maxime Ripard <maxime.ripard@free-electrons.com>
>>
>> The sunxi_sid driver doesn't check for kmalloc return status before
>> derefencing the returned pointer, which could lead to a NULL pointer
>> dereference if kmalloc failed. Check for its return code to make sure it
>> deosn't happen.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> ---
>>   drivers/nvmem/sunxi_sid.c | 11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> No signed-off-by: from you on this patch?
>

Oops!! My bad I missed the sign-off.

Thanks for taking this patch, I will make sure I will recheck this 
before sending.

--srini

> :(
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] nvmem: sunxi: Check for memory allocation failure Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-09-30 14:40 +0200
  Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 13:10 +0200
    Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-04 16:50 +0200

csiph-web