Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239104

Re: [PATCH] staging: iio: adc: fix comment block coding style issue

Show all headers | View raw

On 10/03/2015 08:32 PM, Hugo Camboulive wrote:
> This patch to ad7746.c makes the comment block end with a */
> on a separate line.
> 
> Signed-off-by: Hugo Camboulive <hugo.camboulive@gmail.com>
> ---
>  drivers/staging/iio/cdc/ad7746.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 10fa372..8445ddd 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -531,7 +531,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev,
>  		/* CAPDAC Scale = 21pF_typ / 127
>  		 * CIN Scale = 8.192pF / 2^24
>  		 * Offset Scale = CAPDAC Scale / CIN Scale = 338646
> -		 * */
> +		 */

Looks good, but while you are at it please also fix the beginning of the
comment. Kernel style multi-line comments look like

/*
 * text
 * more text
 */

So the line with the /* should have any text.

Bonus points if you can also fix all other occurrences of this style error
in the same file.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: iio: adc: fix comment block coding style issue Hugo Camboulive <hugo.camboulive@gmail.com> - 2015-10-03 18:40 +0200
  Re: [PATCH] staging: iio: adc: fix comment block coding style issue Lars-Peter Clausen <lars@metafoo.de> - 2015-10-04 14:00 +0200
    [PATCH v2] staging: iio: adc: fix comment block coding style issue Hugo Camboulive <hugo.camboulive@gmail.com> - 2015-10-04 16:40 +0200
      Re: [PATCH v2] staging: iio: adc: fix comment block coding style  issue Jonathan Cameron <jic23@kernel.org> - 2015-10-04 16:50 +0200

csiph-web