Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229568

RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

Show all headers | View raw

On Mon, 21 Sep 2015, Manoil Claudiu wrote:
> >The device is set as wakeup capable using proper wakeup API but the
> >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source
> >which is incorrect.
> >
> >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with
> >enable_irq_wake instead.
> >
> 
> What would be the purpose of IRQF_NO_SUSPEND flag then?  The flag is a
> friendlier API compared to calling enable_irq_wake().  For older kernels,

It's not an API, it's just a bandaid for lazy programmers.

> on PPC architectures, the flag did the job.  When did this change? Since
> when using IRQF_NO_SUSPEND is a "misuse"?

It always was. Simply because IRQF_NO_SUSPEND has absolutely nothing
to do with wakeup interrupt sources. It's a flag which excludes the
interrupt from the suspend mechanism, but it does not flag it a wakeup
source.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-21 17:50 +0200
  Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-21 18:40 +0200
  RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND  flag Thomas Gleixner <tglx@linutronix.de> - 2015-09-21 19:00 +0200
    RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Manoil Claudiu <claudiu.manoil@freescale.com> - 2015-09-22 16:30 +0200
      Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-22 17:10 +0200
    Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Li Yang <leoli@freescale.com> - 2015-09-23 23:30 +0200
      Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND  flag Thomas Gleixner <tglx@linutronix.de> - 2015-09-24 00:10 +0200
        Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Li Yang <leoli@freescale.com> - 2015-09-24 23:20 +0200
  RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Manoil Claudiu <claudiu.manoil@freescale.com> - 2015-09-21 19:00 +0200
  Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND  flag David Miller <davem@davemloft.net> - 2015-09-24 23:30 +0200

csiph-web