Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1324750
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] rtc: max77686: fix checkpatch error |
| Date | 2016-02-03 01:00 +0100 |
| Message-ID | <qXT1w-2h3-5@gated-at.bofh.it> (permalink) |
| References | <qXJbP-3xo-3@gated-at.bofh.it> <qXJbQ-3xo-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02.02.2016 22:16, Laxman Dewangan wrote:
> Fix following check patch error in rtc-max77686 driver:
> - Alignment should match open parenthesis.
> - braces {} should be used on all arms of this statement.
> - Prefer using the BIT macro
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> drivers/rtc/rtc-max77686.c | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested on Trats2/max77686:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
[PATCH 1/4] rtc: max77686: fix checkpatch error Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
Re: [PATCH 1/4] rtc: max77686: fix checkpatch error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 01:00 +0100
Re: [PATCH 1/4] rtc: max77686: fix checkpatch error Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:10 +0100
[PATCH 3/4] rtc: max77686: avoid reference of parent device info multiple palces Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
Re: [PATCH 3/4] rtc: max77686: avoid reference of parent device info multiple palces Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:20 +0100
[PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 01:00 +0100
Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:10 +0100
[PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
Re: [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq chip locally Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 02:20 +0100
Re: [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq chip locally Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:50 +0100
csiph-web