Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324084

[PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers

Show all headers | View raw

rtc_regmap should be used to access all RTC regsiters instead
of parent regmap regardless of what chip or property have it.

This makes the register access uniform and extendible for other
chips.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
CC: Javier Martinez Canillas <javier@osg.samsung.com>
---
 drivers/rtc/rtc-max77686.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 253cf12..11f74ed 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -370,7 +370,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 			goto out;
 		}
 
-		ret = regmap_read(info->max77686->regmap,
+		ret = regmap_read(info->max77686->rtc_regmap,
 				  map[REG_RTC_AE1], &val);
 		if (ret < 0) {
 			dev_err(info->dev,
@@ -426,7 +426,8 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info)
 			goto out;
 		}
 
-		ret = regmap_write(info->max77686->regmap, map[REG_RTC_AE1], 0);
+		ret = regmap_write(info->max77686->rtc_regmap,
+				   map[REG_RTC_AE1], 0);
 	} else {
 		ret = regmap_bulk_read(info->max77686->rtc_regmap,
 				       map[REG_ALARM1_SEC], data,
@@ -471,7 +472,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info)
 		goto out;
 
 	if (info->drv_data->alarm_enable_reg) {
-		ret = regmap_write(info->max77686->regmap, map[REG_RTC_AE1],
+		ret = regmap_write(info->max77686->rtc_regmap, map[REG_RTC_AE1],
 				   MAX77802_ALARM_ENABLE_VALUE);
 	} else {
 		ret = regmap_bulk_read(info->max77686->rtc_regmap,
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
  [PATCH 1/4] rtc: max77686: fix checkpatch error Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 1/4] rtc: max77686: fix checkpatch error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 01:00 +0100
    Re: [PATCH 1/4] rtc: max77686: fix checkpatch error Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:10 +0100
  [PATCH 3/4] rtc: max77686: avoid reference of parent device info multiple palces Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 3/4] rtc: max77686: avoid reference of parent device info  multiple palces Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:20 +0100
  [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 01:00 +0100
    Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:10 +0100
  [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap,  irq chip locally Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 02:20 +0100
      Re: [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq  chip locally Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:50 +0100

csiph-web