Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324855

Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers

Show all headers | View raw

Hello Laxman

On 02/02/2016 10:16 AM, Laxman Dewangan wrote:
> rtc_regmap should be used to access all RTC regsiters instead

s/regsiters/registers

> of parent regmap regardless of what chip or property have it.
>
> This makes the register access uniform and extendible for other
> chips.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>   drivers/rtc/rtc-max77686.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>

Thanks for the patch, I indeed should had used rtc_regmap for consistency.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
  [PATCH 1/4] rtc: max77686: fix checkpatch error Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 1/4] rtc: max77686: fix checkpatch error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 01:00 +0100
    Re: [PATCH 1/4] rtc: max77686: fix checkpatch error Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:10 +0100
  [PATCH 3/4] rtc: max77686: avoid reference of parent device info multiple palces Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 3/4] rtc: max77686: avoid reference of parent device info  multiple palces Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:20 +0100
  [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 01:00 +0100
    Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:10 +0100
  [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-02 14:30 +0100
    Re: [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap,  irq chip locally Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-03 02:20 +0100
      Re: [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq  chip locally Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-03 04:50 +0100

csiph-web