Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1311885

Re: [PATCH] README: cosmetic fixes

From Diego Viola <diego.viola@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] README: cosmetic fixes
Date 2016-01-19 02:40 +0100
Message-ID <qStr4-D8-5@gated-at.bofh.it> (permalink)
References (1 earlier) <qEeif-1qh-31@gated-at.bofh.it> <qS4sF-nf-1@gated-at.bofh.it> <qSeBH-7bZ-3@gated-at.bofh.it> <qSo83-5hQ-17@gated-at.bofh.it> <qSqMx-7dB-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jan 18, 2016 at 8:40 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> On Mon, 18 Jan 2016 17:53:02 -0200
> Diego Viola <diego.viola@gmail.com> wrote:
>
>> The thing I'm unsure about is that the pull request contained trivial
>> changes from others as well, and my patch was trivial, yes.
>>
>> So why not include my changes with the other trivial changes as well?
>
> I set aside when I raised my initial complaint, and it stayed set aside.

After your complaint, I provided and suggested examples about
improving the section in the README that you complained about, I also
asked for your feedback, but you remained silent.

I was hoping to get your feedback and we would improve that section together.

>
> I'll consider it again, but I'm not very enthusiastic about applying
> stylistic fixes.  We really don't need trivial patch wars over how many
> exclamation points belong on a given sentence.

I understand, but the exclamation point is just one fix, there are
other fixes in my patch.

>
> Diego, I'd like to ask you to sit back a bit and think about what you are
> really trying to accomplish.  Maintainers are busy people, and you place a
> demand on their time whenever you post a patch.  That time is available in
> *very* limited quantities for patches that don't really make the kernel
> better.  Please think a bit about why you're doing this, and how you might
> direct your energy toward creating changes that maintainers actively want
> to apply.  That will leave everybody better off than nagging people about
> cosmetic changes.

I'm just trying to improve the documentation, I want to improve the
state of the documentation and the README, why is this so hard to do?

I understand you don't have the time to review small patches like
mine, so wouldn't it make sense to delegate this work or activity to
someone else that has the time?

>
> Thanks,
>
> jon

Thanks,

Diego

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 00:00 +0100
  Re: [PATCH] README: cosmetic fixes Jiri Kosina <jikos@kernel.org> - 2016-01-18 10:50 +0100
    Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 14:50 +0100
    Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 21:00 +0100
      Re: [PATCH] README: cosmetic fixes Jonathan Corbet <corbet@lwn.net> - 2016-01-18 23:50 +0100
        Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 02:40 +0100
          Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 03:50 +0100
            Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 07:30 +0100

csiph-web