Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1311885

Re: [PATCH] README: cosmetic fixes

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Diego Viola <diego.viola@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] README: cosmetic fixes
Date Tue, 19 Jan 2016 02:40:02 +0100
Message-ID <qStr4-D8-5@gated-at.bofh.it> (permalink)
References <qCr9U-5ju-5@gated-at.bofh.it> <qEeif-1qh-31@gated-at.bofh.it> <qS4sF-nf-1@gated-at.bofh.it> <qSeBH-7bZ-3@gated-at.bofh.it> <qSo83-5hQ-17@gated-at.bofh.it> <qSqMx-7dB-5@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+MjGlyyQj1M60RsLs50HidDlr9ATaLRRvQBJx60wbWA=; b=GFEL7l+sDC5uwE4zH8FdXeEgxLN8g8lUGdxsqwTKhtUUf8EHUbtE+pGK4yvJwvnKsY J4pRP6wyqvru4SzYFzuJfdtxWymYs2WasfDnFLY/ehbhI0bznTvneatvkfNS8Bphn91c zKlqdvbmQxnUFSW7bjk86q/lirJZUyfiB37on23evjD0iYr0aB8QXRrofXaRIhS28BKg 2qDkqp5NRup6t/YgEP91J8bu3kBT6sA4OBCgI8LmPvW9r90PhKQ6WPfWwzTFlUIdBE3D KinpyQwDHzb78/ZrICLOnj5CMAQ1qMyvFW6CQZO/Jyzwe6MdWipM3pXrkq1PFaJhZvaf NccQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+MjGlyyQj1M60RsLs50HidDlr9ATaLRRvQBJx60wbWA=; b=KbrZSSlRG9j0eTi7+S4PTMPjI8BvxDXZFa2EuF+TxlLicEeSv6kygGjwqHlnlD5ojz byG5jY7JXpGNxxwNewf4BModkeL5elnCl51IRjSfk8u9AzVBBA3oDwjwfVplmJH+3QxJ 7rzXvD7+0Hsp2WtN1Cu8WUUFercgcQXpo0louDEhDPmgrDaG8cvYWZ4RIflDpBtXqcMc 4m2G0OSuAPb8Oms4dVnTIXvAE5R/nIUvkl7PFPArL7/BcbWNyI3NPeQQ3nakCFYhg8zb 8sjSssowjUI0akg921FYXk1oMdaqE+xaFtT5bDyGSC40g1ax7xAHG7bP2cJaogMUbtz6 ebsw==
X-Gm-Message-State AG10YOTcagRobpOL7tJb2AoUcTrG/iF3P7Lz7k6slVxXMGce524k1qtvlj6aOdv3r/S0JiEb42yGANHoxKpEtQ==
MIME-Version 1.0
X-Received by 10.50.29.110 with SMTP id j14mr13576286igh.87.1453167141215; Mon, 18 Jan 2016 17:32:21 -0800 (PST)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 50
Organization linux.* mail to news gateway
X-Original-Cc Jiri Kosina <jikos@kernel.org>, linux-kernel@vger.kernel.org
X-Original-Date Mon, 18 Jan 2016 23:32:21 -0200
X-Original-Message-ID <CA+ToGPE32OLDL1ucp+mNkGexDE2CakY-Sju-1fsL_AtuHb8MYg@mail.gmail.com>
X-Original-References <1449345010-12512-1-git-send-email-diego.viola@gmail.com> <20151210113423.168f8b4d@lwn.net> <CA+ToGPEKnUeFtoDN9a9FBTbO5h06mDdN3i9V0cAka49JOedREA@mail.gmail.com> <alpine.LNX.2.00.1601181042170.21446@cbobk.fhfr.pm> <CA+ToGPFL5bC2GSir9O2A+bF51wfDJoAh4NCex=OGH2cmxwEm5g@mail.gmail.com> <20160118154035.31455402@lwn.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1311885

Show key headers only | View raw


On Mon, Jan 18, 2016 at 8:40 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> On Mon, 18 Jan 2016 17:53:02 -0200
> Diego Viola <diego.viola@gmail.com> wrote:
>
>> The thing I'm unsure about is that the pull request contained trivial
>> changes from others as well, and my patch was trivial, yes.
>>
>> So why not include my changes with the other trivial changes as well?
>
> I set aside when I raised my initial complaint, and it stayed set aside.

After your complaint, I provided and suggested examples about
improving the section in the README that you complained about, I also
asked for your feedback, but you remained silent.

I was hoping to get your feedback and we would improve that section together.

>
> I'll consider it again, but I'm not very enthusiastic about applying
> stylistic fixes.  We really don't need trivial patch wars over how many
> exclamation points belong on a given sentence.

I understand, but the exclamation point is just one fix, there are
other fixes in my patch.

>
> Diego, I'd like to ask you to sit back a bit and think about what you are
> really trying to accomplish.  Maintainers are busy people, and you place a
> demand on their time whenever you post a patch.  That time is available in
> *very* limited quantities for patches that don't really make the kernel
> better.  Please think a bit about why you're doing this, and how you might
> direct your energy toward creating changes that maintainers actively want
> to apply.  That will leave everybody better off than nagging people about
> cosmetic changes.

I'm just trying to improve the documentation, I want to improve the
state of the documentation and the README, why is this so hard to do?

I understand you don't have the time to review small patches like
mine, so wouldn't it make sense to delegate this work or activity to
someone else that has the time?

>
> Thanks,
>
> jon

Thanks,

Diego

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 00:00 +0100
  Re: [PATCH] README: cosmetic fixes Jiri Kosina <jikos@kernel.org> - 2016-01-18 10:50 +0100
    Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 14:50 +0100
    Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 21:00 +0100
      Re: [PATCH] README: cosmetic fixes Jonathan Corbet <corbet@lwn.net> - 2016-01-18 23:50 +0100
        Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 02:40 +0100
          Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 03:50 +0100
            Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 07:30 +0100

csiph-web