Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1311836

Re: [PATCH] README: cosmetic fixes

From Jonathan Corbet <corbet@lwn.net>
Newsgroups linux.kernel
Subject Re: [PATCH] README: cosmetic fixes
Date 2016-01-18 23:50 +0100
Message-ID <qSqMx-7dB-5@gated-at.bofh.it> (permalink)
References <qCr9U-5ju-5@gated-at.bofh.it> <qEeif-1qh-31@gated-at.bofh.it> <qS4sF-nf-1@gated-at.bofh.it> <qSeBH-7bZ-3@gated-at.bofh.it> <qSo83-5hQ-17@gated-at.bofh.it>
Organization LWN.net

Show all headers | View raw


On Mon, 18 Jan 2016 17:53:02 -0200
Diego Viola <diego.viola@gmail.com> wrote:

> The thing I'm unsure about is that the pull request contained trivial
> changes from others as well, and my patch was trivial, yes.
> 
> So why not include my changes with the other trivial changes as well?

I set aside when I raised my initial complaint, and it stayed set aside.

I'll consider it again, but I'm not very enthusiastic about applying
stylistic fixes.  We really don't need trivial patch wars over how many
exclamation points belong on a given sentence.

Diego, I'd like to ask you to sit back a bit and think about what you are
really trying to accomplish.  Maintainers are busy people, and you place a
demand on their time whenever you post a patch.  That time is available in
*very* limited quantities for patches that don't really make the kernel
better.  Please think a bit about why you're doing this, and how you might
direct your energy toward creating changes that maintainers actively want
to apply.  That will leave everybody better off than nagging people about
cosmetic changes.

Thanks,

jon

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 00:00 +0100
  Re: [PATCH] README: cosmetic fixes Jiri Kosina <jikos@kernel.org> - 2016-01-18 10:50 +0100
    Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 14:50 +0100
    Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-18 21:00 +0100
      Re: [PATCH] README: cosmetic fixes Jonathan Corbet <corbet@lwn.net> - 2016-01-18 23:50 +0100
        Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 02:40 +0100
          Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 03:50 +0100
            Re: [PATCH] README: cosmetic fixes Diego Viola <diego.viola@gmail.com> - 2016-01-19 07:30 +0100

csiph-web