Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1311200

Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options

From Caleb Crome <caleb@crome.org>
Newsgroups linux.kernel
Subject Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options
Date 2016-01-18 00:40 +0100
Message-ID <qS55n-Rw-3@gated-at.bofh.it> (permalink)
References (6 earlier) <qRhrY-1xr-17@gated-at.bofh.it> <qRhBE-1AN-15@gated-at.bofh.it> <qRhLk-1DX-11@gated-at.bofh.it> <qRi4G-204-21@gated-at.bofh.it> <qRzRU-5pL-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Okay, I'll submit a patch that does the following:

fsl,mpc8610:  using DMA=fifo_depth-2 (unchanged from current), using
FIQ=fifo_depth  (unchanged from current).

all others that are marked with 'imx':  watermark&maxburst = 4 for DMA
(new setting).  watermark = fifo_depth for FIQ (unchanged from
previous).

-Caleb



On Sat, Jan 16, 2016 at 6:15 AM, Timur Tabi <timur@tabi.org> wrote:
> Caleb Crome wrote:
>>
>> I see the 4 compatibles are:  fsl,mpc8610-ssi, fsl,imx51-ssi,
>> fsl,imx35-ssi, and fsl,imx21-ssi.
>>
>> Shall I submit a patch that sets the value to 4 for for any/all of the
>> above?  Should it be different based on whether fiq is enabled.  Maybe
>> set it to 4 for whenever DMA is used, and to 13 whenever FIQ is used?
>
>
> Do NOT change the watermark value for fsl,mpc8610-ssi from whatever it is
> today.  You would need to retest your code on an mpc8610 and p1022ds, and I
> don't think you have either of those boards.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Mark Brown <broonie@kernel.org> - 2016-01-15 14:20 +0100
  Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 14:50 +0100
    Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 18:10 +0100
      Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 19:40 +0100
        Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 19:50 +0100
          Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 20:00 +0100
            Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 20:20 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 20:30 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 20:50 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-16 15:20 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-18 00:40 +0100
        Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 21:00 +0100

csiph-web