Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options

Path	csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Caleb Crome <caleb@crome.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options
Date	Mon, 18 Jan 2016 00:40:01 +0100
Message-ID	<qS55n-Rw-3@gated-at.bofh.it> (permalink)
References	<qQSWE-197-63@gated-at.bofh.it> <qQWxc-3FW-17@gated-at.bofh.it> <qR1wR-7l7-3@gated-at.bofh.it> <qRcsh-6zK-1@gated-at.bofh.it> <qRcVj-6OR-7@gated-at.bofh.it> <qRg2T-Ih-21@gated-at.bofh.it> <qRhrY-1xr-17@gated-at.bofh.it> <qRhBE-1AN-15@gated-at.bofh.it> <qRhLk-1DX-11@gated-at.bofh.it> <qRi4G-204-21@gated-at.bofh.it> <qRzRU-5pL-3@gated-at.bofh.it>
X-Original-To	Timur Tabi <timur@tabi.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=crome-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=CtJlcKjVNPqA4sy7VZQLIowvU94cVyVFH44KLMtRcT4=; b=dN6PE2B21jOnCnAbV4vIokyVQeuJwN6v5iWcMZRPUSCa52n72MzT8XPZt5m2tFh4Hw stxITexyTW0LFmz7A771JYRQLAiJpAruWYUkQ92lYHgR05P2g0FGr7lVjAWrJlcYFqUE lx3Ce23xYpdZp30KChCzS9c+D3PHEuXQhNxVnRatmtPTVHvlzdqz7zyI9W6VZPiMDOzO Wvc8ABE4hS8MO7QFYRM+cX3qIouXP/cQhB4NLSwfegSz00+WCdaCxZNPQG6xog5EMVmZ p/XHkiFR44vDVcj3LdUUa0mLCBKJGo7AqAfxUfd9TxKJYtcEXboTMDRFXsLgL7seAuQA XNsw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=CtJlcKjVNPqA4sy7VZQLIowvU94cVyVFH44KLMtRcT4=; b=crasOm6keHTjfoPsFRiniQyopIXZODMJzhCNjoDACBlSuH6ADHfhxNST8Ll3w8lnHJ OCMpaa+GAiblAYtVuTdJM0nz+d/KONdte5WsTwALSn3W6H/YBEwLEyA9G4grnsrDzOh7 Y6taXbeSrANM31aZIiCp16YmfU16ddd3f71xo9BX0WPa/q9v9gjQe9rP6E5ISgvXUG/C IG0npIdsF5mJnkQ0NJuCp+BxbxUZdoscnRAFNJaTioEafjukpNHztMcu6vZd+Wz6Jsom 0htgLIw440ueUIcuGff8I5kfVLSivB7qDUjx0Fz8xGB5glrRZITyJW5Cl5AG3626gLVp wmFA==
X-Gm-Message-State	AG10YOSos/ZVpqDfFMWGSyegkcLQGHZWEU+4YKkrcDlGWkisoBQGQ3zlLmhSCFsm9UpAg+L8KGmhXCJVOv4W1g==
X-Received	by 10.50.111.111 with SMTP id ih15mr8423311igb.78.1453073718849; Sun, 17 Jan 2016 15:35:18 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Nicolin Chen <nicoleotsuka@gmail.com>, Mark Brown <broonie@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
X-Original-Date	Sun, 17 Jan 2016 15:34:59 -0800
X-Original-Message-ID	<CAG5mAdzN0j0fEsDcZMPUTPQtf9vSyyHYUE4HVisu_MxVBVAxOg@mail.gmail.com>
X-Original-References	<1452788982-11583-1-git-send-email-caleb@crome.org> <20160114201858.GA17567@Asurada-Nvidia> <56984BE7.2050303@tabi.org> <20160115131325.GW6588@sirena.org.uk> <5698F846.5080604@tabi.org> <CAG5mAdy553q4Te5755575WaiLxGRp43h=WVH6QzF7idsaCnhbg@mail.gmail.com> <20160115183824.GB31703@Asurada-Nvidia> <CAG5mAdyXPtnnZvGcWrhhbv7wuamz_xbRsn76VXdbE1yZRgx_Mg@mail.gmail.com> <20160115185736.GC31703@Asurada-Nvidia> <CAG5mAdyUfSuCqA4_342MS2AyshvuyeiYsjQyRqifmqVhn4T2xA@mail.gmail.com> <569A5085.10806@tabi.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1311200

Show key headers only | View raw

Okay, I'll submit a patch that does the following:

fsl,mpc8610:  using DMA=fifo_depth-2 (unchanged from current), using
FIQ=fifo_depth  (unchanged from current).

all others that are marked with 'imx':  watermark&maxburst = 4 for DMA
(new setting).  watermark = fifo_depth for FIQ (unchanged from
previous).

-Caleb

On Sat, Jan 16, 2016 at 6:15 AM, Timur Tabi <timur@tabi.org> wrote:
> Caleb Crome wrote:
>>
>> I see the 4 compatibles are:  fsl,mpc8610-ssi, fsl,imx51-ssi,
>> fsl,imx35-ssi, and fsl,imx21-ssi.
>>
>> Shall I submit a patch that sets the value to 4 for for any/all of the
>> above?  Should it be different based on whether fiq is enabled.  Maybe
>> set it to 4 for whenever DMA is used, and to 13 whenever FIQ is used?
>
>
> Do NOT change the watermark value for fsl,mpc8610-ssi from whatever it is
> today.  You would need to retest your code on an mpc8610 and p1022ds, and I
> don't think you have either of those boards.

Thread

Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Mark Brown <broonie@kernel.org> - 2016-01-15 14:20 +0100
  Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 14:50 +0100
    Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 18:10 +0100
      Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 19:40 +0100
        Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 19:50 +0100
          Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 20:00 +0100
            Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 20:20 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 20:30 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 20:50 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-16 15:20 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-18 00:40 +0100
        Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 21:00 +0100

csiph-web