Path: csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From: Caleb Crome <caleb@crome.org>
Newsgroups: linux.kernel
Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options
Date: Mon, 18 Jan 2016 00:40:01 +0100
Message-ID: <qS55n-Rw-3@gated-at.bofh.it>
References: <qQSWE-197-63@gated-at.bofh.it> <qQWxc-3FW-17@gated-at.bofh.it> <qR1wR-7l7-3@gated-at.bofh.it> <qRcsh-6zK-1@gated-at.bofh.it> <qRcVj-6OR-7@gated-at.bofh.it> <qRg2T-Ih-21@gated-at.bofh.it> <qRhrY-1xr-17@gated-at.bofh.it> <qRhBE-1AN-15@gated-at.bofh.it> <qRhLk-1DX-11@gated-at.bofh.it> <qRi4G-204-21@gated-at.bofh.it> <qRzRU-5pL-3@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 27
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1311200

Okay, I'll submit a patch that does the following:

fsl,mpc8610:  using DMA=fifo_depth-2 (unchanged from current), using
FIQ=fifo_depth  (unchanged from current).

all others that are marked with 'imx':  watermark&maxburst = 4 for DMA
(new setting).  watermark = fifo_depth for FIQ (unchanged from
previous).

-Caleb



On Sat, Jan 16, 2016 at 6:15 AM, Timur Tabi <timur@tabi.org> wrote:
> Caleb Crome wrote:
>>
>> I see the 4 compatibles are:  fsl,mpc8610-ssi, fsl,imx51-ssi,
>> fsl,imx35-ssi, and fsl,imx21-ssi.
>>
>> Shall I submit a patch that sets the value to 4 for for any/all of the
>> above?  Should it be different based on whether fiq is enabled.  Maybe
>> set it to 4 for whenever DMA is used, and to 13 whenever FIQ is used?
>
>
> Do NOT change the watermark value for fsl,mpc8610-ssi from whatever it is
> today.  You would need to retest your code on an mpc8610 and p1022ds, and I
> don't think you have either of those boards.