Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311088

[PATCH] Remove logging for "Unsupported brightness interface"

Show all headers | View raw

Message gets logged on machines that are well supported.
Fixed one checkpatch.pl ERROR also.

Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 0bed473..b149dec 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
brightness_quirk_table[] __initconst = {
  */
 static void __init tpacpi_detect_brightness_capabilities(void)
 {
- unsigned int b;
+ const unsigned int b = tpacpi_check_std_acpi_brightness_support();

  vdbg_printk(TPACPI_DBG_INIT,
     "detecting firmware brightness interface capabilities\n");
@@ -6447,7 +6447,6 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
  * Lenovo Vista BIOS to ACPI brightness mode even if we are not
  * going to publish a backlight interface
  */
- b = tpacpi_check_std_acpi_brightness_support();
  switch (b) {
  case 16:
  bright_maxlvl = 15;
@@ -6459,7 +6458,6 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
  pr_info("detected a 8-level brightness capable ThinkPad\n");
  break;
  default:
- pr_info("Unsupported brightness interface\n");
  tp_features.bright_unkfw = 1;
  bright_maxlvl = b - 1;
  }
@@ -7440,7 +7438,7 @@ static struct ibm_struct volume_driver_data = {

 #define alsa_card NULL

-static void inline volume_alsa_notify_change(void)
+static inline void volume_alsa_notify_change(void)
 {
 }

-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-17 00:50 +0100
  Re: [PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-21 12:20 +0100
    Re: [PATCH] Remove logging for "Unsupported brightness interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-21 15:00 +0100
      Re: [PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-26 20:50 +0100

csiph-web