Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311088 > unrolled thread

[PATCH] Remove logging for "Unsupported brightness interface"

Back to article view | Back to linux.kernel

Contents

  [PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-17 00:50 +0100
    Re: [PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-21 12:20 +0100
      Re: [PATCH] Remove logging for "Unsupported brightness interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-21 15:00 +0100
        Re: [PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-26 20:50 +0100

#1311088 — [PATCH] Remove logging for "Unsupported brightness interface"

Message gets logged on machines that are well supported.
Fixed one checkpatch.pl ERROR also.

Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 0bed473..b149dec 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
brightness_quirk_table[] __initconst = {
  */
 static void __init tpacpi_detect_brightness_capabilities(void)
 {
- unsigned int b;
+ const unsigned int b = tpacpi_check_std_acpi_brightness_support();

  vdbg_printk(TPACPI_DBG_INIT,
     "detecting firmware brightness interface capabilities\n");
@@ -6447,7 +6447,6 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
  * Lenovo Vista BIOS to ACPI brightness mode even if we are not
  * going to publish a backlight interface
  */
- b = tpacpi_check_std_acpi_brightness_support();
  switch (b) {
  case 16:
  bright_maxlvl = 15;
@@ -6459,7 +6458,6 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
  pr_info("detected a 8-level brightness capable ThinkPad\n");
  break;
  default:
- pr_info("Unsupported brightness interface\n");
  tp_features.bright_unkfw = 1;
  bright_maxlvl = b - 1;
  }
@@ -7440,7 +7438,7 @@ static struct ibm_struct volume_driver_data = {

 #define alsa_card NULL

-static void inline volume_alsa_notify_change(void)
+static inline void volume_alsa_notify_change(void)
 {
 }

-- 
2.5.0

[toc] | [next] | [standalone]

#1314112

On 16 January 2016 at 23:43, Eric Curtin <ericcurtin17@gmail.com> wrote:
> Message gets logged on machines that are well supported.
> Fixed one checkpatch.pl ERROR also.
>
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> ---
>  drivers/platform/x86/thinkpad_acpi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index 0bed473..b149dec 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
> brightness_quirk_table[] __initconst = {
>   */
>  static void __init tpacpi_detect_brightness_capabilities(void)
>  {
> - unsigned int b;
> + const unsigned int b = tpacpi_check_std_acpi_brightness_support();
>
>   vdbg_printk(TPACPI_DBG_INIT,
>      "detecting firmware brightness interface capabilities\n");
> @@ -6447,7 +6447,6 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
>   * Lenovo Vista BIOS to ACPI brightness mode even if we are not
>   * going to publish a backlight interface
>   */
> - b = tpacpi_check_std_acpi_brightness_support();
>   switch (b) {
>   case 16:
>   bright_maxlvl = 15;
> @@ -6459,7 +6458,6 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
>   pr_info("detected a 8-level brightness capable ThinkPad\n");
>   break;
>   default:
> - pr_info("Unsupported brightness interface\n");
>   tp_features.bright_unkfw = 1;
>   bright_maxlvl = b - 1;
>   }
> @@ -7440,7 +7438,7 @@ static struct ibm_struct volume_driver_data = {
>
>  #define alsa_card NULL
>
> -static void inline volume_alsa_notify_change(void)
> +static inline void volume_alsa_notify_change(void)
>  {
>  }
>
> --
> 2.5.0

Hi Guys,

Sorry to be bugging you. Is this going to be accepted or not? Just a poke! :)

[toc] | [prev] | [next] | [standalone]

#1314209

On Thu, Jan 21, 2016, at 09:18, Eric Curtin wrote:
> On 16 January 2016 at 23:43, Eric Curtin <ericcurtin17@gmail.com> wrote:
> > Message gets logged on machines that are well supported.
> > Fixed one checkpatch.pl ERROR also.
> >
> > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> > ---
> >  drivers/platform/x86/thinkpad_acpi.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
> > b/drivers/platform/x86/thinkpad_acpi.c
> > index 0bed473..b149dec 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
> > brightness_quirk_table[] __initconst = {
> >   */
> >  static void __init tpacpi_detect_brightness_capabilities(void)
> >  {
> > - unsigned int b;
> > + const unsigned int b = tpacpi_check_std_acpi_brightness_support();

This unrelated change can have side-effects, and I didn't stop to look
at the code yet to know if it is desired.  Regardless, it should be in a
separate patch anyway as it has nothing to do with the removal of the
log message, so please drop it.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[toc] | [prev] | [next] | [standalone]

#1318321

On 23 January 2016 at 00:28, Eric Curtin <ericcurtin17@gmail.com> wrote:
> Message gets logged on machines that are well supported.
>
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> ---
>  drivers/platform/x86/thinkpad_acpi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index a268a7a..4eb41aa 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6661,7 +6661,6 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
>                 pr_info("detected a 8-level brightness capable ThinkPad\n");
>                 break;
>         default:
> -               pr_info("Unsupported brightness interface\n");
>                 tp_features.bright_unkfw = 1;
>                 bright_maxlvl = b - 1;
>         }
> --
> 2.5.0
>

Hi Guys,

This patch doesn't appear on any of the Linux kernel archive sites.
Could somebody enlighten me why this is so?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web