Re: [PATCH] Remove logging for "Unsupported brightness interface"

From	Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Remove logging for "Unsupported brightness interface"
Date	2016-01-21 15:00 +0100
Message-ID	<qTnWi-5YM-23@gated-at.bofh.it> (permalink)
References	<qRILw-2SY-5@gated-at.bofh.it> <qTlrs-4u1-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 21, 2016, at 09:18, Eric Curtin wrote:
> On 16 January 2016 at 23:43, Eric Curtin <ericcurtin17@gmail.com> wrote:
> > Message gets logged on machines that are well supported.
> > Fixed one checkpatch.pl ERROR also.
> >
> > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> > ---
> >  drivers/platform/x86/thinkpad_acpi.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
> > b/drivers/platform/x86/thinkpad_acpi.c
> > index 0bed473..b149dec 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
> > brightness_quirk_table[] __initconst = {
> >   */
> >  static void __init tpacpi_detect_brightness_capabilities(void)
> >  {
> > - unsigned int b;
> > + const unsigned int b = tpacpi_check_std_acpi_brightness_support();

This unrelated change can have side-effects, and I didn't stop to look
at the code yet to know if it is desired.  Regardless, it should be in a
separate patch anyway as it has nothing to do with the removal of the
log message, so please drop it.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Thread

[PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-17 00:50 +0100
  Re: [PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-21 12:20 +0100
    Re: [PATCH] Remove logging for "Unsupported brightness interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-21 15:00 +0100
      Re: [PATCH] Remove logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-26 20:50 +0100

csiph-web