Re: [PATCH 1/2] input: gpio-keys: add support for disable button from DT

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] input: gpio-keys: add support for disable button from DT
Date	2016-01-12 22:20 +0100
Message-ID	<qQewa-6zc-7@gated-at.bofh.it> (permalink)
References	<qQ5Cx-jP-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 12, 2016 at 05:02:49PM +0530, Laxman Dewangan wrote:
> Add support to disable the button from DT via status property
> if given button is not supporting on given platforms.
> 
> This will help to re-use the existing dtsi file with status
> enable/disable across platforms.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>  drivers/input/keyboard/gpio_keys.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
> index bef317f..cf068cb 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -632,6 +632,14 @@ gpio_keys_get_devtree_pdata(struct device *dev)
>  	for_each_child_of_node(node, pp) {
>  		enum of_gpio_flags flags;
>  
> +		/* Ignore the button if status of node is disabled */
> +		error = of_device_is_available(pp);
> +		if (!error) {
> +			dev_info(dev, "Button %s is ignored\n", pp->name);

I'd rather have it as dev_dbg() please.

> +			pdata->nbuttons--;
> +			continue;
> +		}
> +
>  		button = &pdata->buttons[i++];
>  
>  		button->gpio = of_get_gpio_flags(pp, 0, &flags);
> -- 
> 2.1.4
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] input: gpio-keys: add support for disable button from DT Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 12:50 +0100
  [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 12:50 +0100
    Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Rob Herring <robh@kernel.org> - 2016-01-12 15:50 +0100
      Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 16:10 +0100
        Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Rob Herring <robh@kernel.org> - 2016-01-12 16:30 +0100
          Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 16:40 +0100
            Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Linus Walleij <linus.walleij@linaro.org> - 2016-01-14 10:20 +0100
  Re: [PATCH 1/2] input: gpio-keys: add support for disable button  from DT Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-12 22:20 +0100

csiph-web