Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307535

Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys

Show all headers | View raw

On Tue, Jan 12, 2016 at 8:55 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
> On Tuesday 12 January 2016 08:13 PM, Rob Herring wrote:
>>
>> On Tue, Jan 12, 2016 at 05:02:50PM +0530, Laxman Dewangan wrote:
>>>
>>> Add support from DT to name the gpio-keys driver to have
>>> desired key name for this input system.
>>>
>>> This helps userspace code to get name and perform proper
>>> event to key mapping in some of cases. In android, the
>>> user space map the key code to application code using
>>> key character layout and for this it uses the name of
>>> input system.
>>
>> Why is specifying the key code not enough?
>
>
> This is the name for input system instead of individual keys.
> In android system, the key mapping is done in user space. By having name
> offers to specifying the customized key character layout instead of generic
> one form android which is fall-back.

Okay, got it.

>>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>>> ---
>>>   Documentation/devicetree/bindings/input/gpio-keys.txt | 1 +
>>>   drivers/input/keyboard/gpio_keys.c                    | 2 ++
>>>   2 files changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt
>>> b/Documentation/devicetree/bindings/input/gpio-keys.txt
>>> index cf1333d..2e6bcd2 100644
>>> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
>>> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
>>> @@ -4,6 +4,7 @@ Required properties:
>>>         - compatible = "gpio-keys";
>>>     Optional properties:
>>> +       - gpio-keys,name: String, name of the gpio-keys input system.
>>
>> gpio-keys is not a vendor.
>>
>> Would "label" work for you instead?
>
>
> "label" means node name?

No, the standard label property. See gpio-leds for an example.

>> Either way, I'm concerned this doesn't work for other key bindings
>> which have multiple keys.
>>
>>
>
> This is not for the individual keys, its for input system like
> /sys/class/input/input0/name.

So label is exactly for this purpose of defining user meaningful names.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] input: gpio-keys: add support for disable button from DT Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 12:50 +0100
  [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 12:50 +0100
    Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Rob Herring <robh@kernel.org> - 2016-01-12 15:50 +0100
      Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 16:10 +0100
        Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Rob Herring <robh@kernel.org> - 2016-01-12 16:30 +0100
          Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 16:40 +0100
            Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Linus Walleij <linus.walleij@linaro.org> - 2016-01-14 10:20 +0100
  Re: [PATCH 1/2] input: gpio-keys: add support for disable button  from DT Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-12 22:20 +0100

csiph-web