Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1309107
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys |
| Date | 2016-01-14 10:20 +0100 |
| Message-ID | <qQMeu-4Y2-23@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <qQ5Cy-jP-5@gated-at.bofh.it> <qQ8qK-2kQ-29@gated-at.bofh.it> <qQ8K7-2Id-37@gated-at.bofh.it> <qQ93r-2Pd-11@gated-at.bofh.it> <qQ9d8-2Sx-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jan 12, 2016 at 4:24 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> On Tuesday 12 January 2016 08:53 PM, Rob Herring wrote:
>> On Tue, Jan 12, 2016 at 8:55 AM, Laxman Dewangan <ldewangan@nvidia.com>
>> wrote:
>>>
>>> On Tuesday 12 January 2016 08:13 PM, Rob Herring wrote:
>>>>
>>>> On Tue, Jan 12, 2016 at 05:02:50PM +0530, Laxman Dewangan wrote:
>
>
>> So label is exactly for this purpose of defining user meaningful names.
>>
> Yes, I can use the label for name. I will update the patch.
>
> Just for understanding, is "label" is better property name to pass the
> specific name?
Yes, look at this from
arch/arm64/boot/dts/arm/juno-motherboard.dtsi:
gpio_keys {
compatible = "gpio-keys";
#address-cells = <1>;
#size-cells = <0>;
button@1 {
debounce_interval = <50>;
wakeup-source;
linux,code = <116>;
label = "POWER";
gpios = <&iofpga_gpio0 0 0x4>;
};
button@2 {
debounce_interval = <50>;
wakeup-source;
linux,code = <102>;
label = "HOME";
gpios = <&iofpga_gpio0 1 0x4>;
};
(...)
Currently these names (POWER, HOME etc) appear nicely in
/proc/interrupts, so I guess the same should be used for input?
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] input: gpio-keys: add support for disable button from DT Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 12:50 +0100
[PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 12:50 +0100
Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Rob Herring <robh@kernel.org> - 2016-01-12 15:50 +0100
Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 16:10 +0100
Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Rob Herring <robh@kernel.org> - 2016-01-12 16:30 +0100
Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 16:40 +0100
Re: [PATCH 2/2] input: gpio-keys: add support to name the gpio-keys Linus Walleij <linus.walleij@linaro.org> - 2016-01-14 10:20 +0100
Re: [PATCH 1/2] input: gpio-keys: add support for disable button from DT Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-12 22:20 +0100
csiph-web