Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283446

Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls

Show all headers | View raw

On Thu, 2015-12-03 at 17:45 -0500, Aaron Conole wrote:
> Currently, pr_debug and pr_devel will not elide function call arguments
> appearing in calls to no_printk for these macros. This is because all
> side effects must be honored before proceeding to the 0-value assignment
> in no_printk.
> 
> The behavior is contrary to documentation found in the CodingStyle and
> header file where these functions are declared. 
> 
> This patch corrects that behavior by shunting out the call to no_printk
> completely. The format string is still checked by gcc for correctness, but
> no code seems to be emitted in common cases.
> 
> fixes commit 5264f2f75d86 ("include/linux/printk.h: use and neaten
> no_printk")
> 

The same should/could probably be done for dev_dbg/dev_vdbg
and the netdev and netif variants.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] printk: fix pr_debug and pr_devel to elide function calls Aaron Conole <aconole@redhat.com> - 2015-12-03 23:50 +0100
  Re: [PATCH] printk: fix pr_debug and pr_devel to elide function  calls Joe Perches <joe@perches.com> - 2015-12-04 00:20 +0100
  Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls Aaron Conole <aconole@redhat.com> - 2015-12-04 17:40 +0100
    Re: [PATCH] printk: fix pr_debug and pr_devel to elide function  calls Joe Perches <joe@perches.com> - 2015-12-04 17:50 +0100
  Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls Jason Baron <jbaron@akamai.com> - 2015-12-04 17:40 +0100
    [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments Aaron Conole <aconole@redhat.com> - 2015-12-04 23:00 +0100
      Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments Arnd Bergmann <arnd@arndb.de> - 2015-12-09 13:00 +0100
        Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments Aaron Conole <aconole@redhat.com> - 2015-12-09 16:20 +0100
        Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out  arguments Joe Perches <joe@perches.com> - 2015-12-09 16:50 +0100

csiph-web