Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1283447
| From | Ashok Raj <ashok.raj@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. |
| Date | 2015-12-04 00:20 +0100 |
| Message-ID | <qBLkl-38M-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Linux has logical cpu offline capability. That can be triggered by: # echo 0 > /sys/devices/system/cpu/cpuX/online In Intel Architecture, MCE's are broadcasted to all CPUs in the system. This includes the CPUs marked offline by Linux. Unless the CPU's were removed via an ACPI notification, in which case the cpu's are removed from the cpu_present_map. This patch ensures offline CPU's don't participate in MCE rendezvous, but simply perform clearing some status bits to ensure a second MCE wont cause automatic shutdown. Without the patch, mce_start will increment mce_callin, but mce_start would wait for all online_cpus. So offline cpu's should avoid participating in the rendezvous process. Reviewed-by: Tony Luck <tony.luck@intel.com> Signed-off-by: Ashok Raj <ashok.raj@intel.com> --- arch/x86/kernel/cpu/mcheck/mce.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index c5b0d56..82a0c8b 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -998,6 +998,7 @@ void do_machine_check(struct pt_regs *regs, long error_code) u64 recover_paddr = ~0ull; int flags = MF_ACTION_REQUIRED; int lmce = 0; + unsigned int cpu = smp_processor_id(); ist_enter(regs); @@ -1008,6 +1009,14 @@ void do_machine_check(struct pt_regs *regs, long error_code) mce_gather_info(&m, regs); + /* + * if this cpu is offline, just bail out. + * TBD: looking into adding any logs this offline CPU might have, + * to be collected and reported by the rendezvous master. + */ + if (cpu_is_offline(cpu) && (m.mcgstatus & MCG_STATUS_RIPV)) + goto out; + final = this_cpu_ptr(&mces_seen); *final = m; @@ -1142,8 +1151,8 @@ void do_machine_check(struct pt_regs *regs, long error_code) if (worst > 0) mce_report_event(regs); - mce_wrmsrl(MSR_IA32_MCG_STATUS, 0); out: + mce_wrmsrl(MSR_IA32_MCG_STATUS, 0); sync_core(); if (recover_paddr == ~0ull) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Ashok Raj <ashok.raj@intel.com> - 2015-12-04 00:20 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Greg KH <greg@kroah.com> - 2015-12-04 00:40 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Borislav Petkov <bp@alien8.de> - 2015-12-04 15:40 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. "Raj, Ashok" <ashok.raj@intel.com> - 2015-12-04 17:20 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Borislav Petkov <bp@alien8.de> - 2015-12-04 18:00 +0100
RE: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. "Luck, Tony" <tony.luck@intel.com> - 2015-12-04 18:30 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Borislav Petkov <bp@alien8.de> - 2015-12-04 18:40 +0100
RE: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. "Luck, Tony" <tony.luck@intel.com> - 2015-12-04 19:00 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Borislav Petkov <bp@alien8.de> - 2015-12-04 19:10 +0100
RE: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. "Luck, Tony" <tony.luck@intel.com> - 2015-12-04 19:40 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Borislav Petkov <bp@alien8.de> - 2015-12-04 20:40 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Andy Lutomirski <luto@amacapital.net> - 2015-12-04 23:40 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. "Raj, Ashok" <ashok.raj@intel.com> - 2015-12-05 00:10 +0100
Re: [Patch V0] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Andy Lutomirski <luto@amacapital.net> - 2015-12-05 00:20 +0100
csiph-web