Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments
Date	2015-12-09 16:50 +0100
Message-ID	<qDPaa-1NH-17@gated-at.bofh.it> (permalink)
References	<qC1yO-57z-13@gated-at.bofh.it> <qC6yu-8fV-25@gated-at.bofh.it> <qDLzz-7Ue-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-12-09 at 12:52 +0100, Arnd Bergmann wrote:
> On Friday 04 December 2015 16:51:42 Aaron Conole wrote:
> > --- a/include/linux/printk.h
> > +++ b/include/linux/printk.h
> > @@ -106,13 +106,14 @@ struct va_format {
> >  
> >  /*
> >   * Dummy printk for disabled debugging statements to use whilst maintaining
> > - * gcc's format and side-effect checking.
> > + * gcc's format checking.
> >   */
> > -static inline __printf(1, 2)
> > -int no_printk(const char *fmt, ...)
> > -{
> > -       return 0;
> > -}
> > +#define no_printk(fmt, ...)                    \
> > +do {                                           \
> > +       if (0) {                                \
> > +               printk(fmt, ##__VA_ARGS__);     \
> > +       }                                       \
> > +} while (0)
> >  
> 
> This change breaks compiling lib/842/, at least in some configurations:
> 
> lib/842/842_decompress.c: In function '__do_index':
> lib/842/842_decompress.c:205:12422: error: implicit declaration of function 'no_printk'

Please specify a configuration that fails.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] printk: fix pr_debug and pr_devel to elide function calls Aaron Conole <aconole@redhat.com> - 2015-12-03 23:50 +0100
  Re: [PATCH] printk: fix pr_debug and pr_devel to elide function  calls Joe Perches <joe@perches.com> - 2015-12-04 00:20 +0100
  Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls Aaron Conole <aconole@redhat.com> - 2015-12-04 17:40 +0100
    Re: [PATCH] printk: fix pr_debug and pr_devel to elide function  calls Joe Perches <joe@perches.com> - 2015-12-04 17:50 +0100
  Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls Jason Baron <jbaron@akamai.com> - 2015-12-04 17:40 +0100
    [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments Aaron Conole <aconole@redhat.com> - 2015-12-04 23:00 +0100
      Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments Arnd Bergmann <arnd@arndb.de> - 2015-12-09 13:00 +0100
        Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments Aaron Conole <aconole@redhat.com> - 2015-12-09 16:20 +0100
        Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out  arguments Joe Perches <joe@perches.com> - 2015-12-09 16:50 +0100

csiph-web