Re: [PATCH] staging: unisys: use common return path

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: unisys: use common return path
Date	2015-12-02 06:10 +0100
Message-ID	<qB7PX-2KY-3@gated-at.bofh.it> (permalink)
References	<qAMs9-5Ts-11@gated-at.bofh.it> <qAOaB-726-3@gated-at.bofh.it> <qAUzo-2vH-15@gated-at.bofh.it> <qAVvs-38i-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 01, 2015 at 06:57:24PM +0300, Dan Carpenter wrote:
> On Tue, Dec 01, 2015 at 09:54:50AM -0500, Ben Romer wrote:
> > On 12/01/2015 03:00 AM, Dan Carpenter wrote:
> > >Doing One Err style error handling is often a mistake but it's ok here.
> > 
> > Why is it okay here? I don't understand why this function would be
> > any different than the other places where the code used a goto.
> 
> What I meant was that I'm generally opposed to "common exit paths".
> Mixing all the exit paths together often makes the code more complicated
> and leads to errors.  That makes sense from a common sense perspective

By "common exit path" do you mean mixing up of success and error paths?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-01 07:20 +0100
  Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 09:10 +0100
    Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-01 11:00 +0100
      Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 17:10 +0100
        Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-02 06:00 +0100
  Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 09:10 +0100
    Re: [PATCH] staging: unisys: use common return path Ben Romer <benjamin.romer@unisys.com> - 2015-12-01 16:00 +0100
      Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 17:00 +0100
        Re: [PATCH] staging: unisys: use common return path Ben Romer <benjamin.romer@unisys.com> - 2015-12-01 17:20 +0100
          Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-02 06:10 +0100
        Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-02 06:10 +0100
          Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-02 07:30 +0100

csiph-web