Re: [PATCH] staging: unisys: use common return path

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: unisys: use common return path
Date	2015-12-02 07:30 +0100
Message-ID	<qB95o-3ur-3@gated-at.bofh.it> (permalink)
References	<qAMs9-5Ts-11@gated-at.bofh.it> <qAOaB-726-3@gated-at.bofh.it> <qAUzo-2vH-15@gated-at.bofh.it> <qAVvs-38i-15@gated-at.bofh.it> <qB7PX-2KY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 02, 2015 at 10:32:49AM +0530, Sudip Mukherjee wrote:
> By "common exit path" do you mean mixing up of success and error paths?


Normally it's just the error paths which are mixed together.  Back in
the day, this unisys driver had tons of error handling bugs so that I
didn't even bother reporting them all.

http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/068932.html
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/069073.html

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-01 07:20 +0100
  Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 09:10 +0100
    Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-01 11:00 +0100
      Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 17:10 +0100
        Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-02 06:00 +0100
  Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 09:10 +0100
    Re: [PATCH] staging: unisys: use common return path Ben Romer <benjamin.romer@unisys.com> - 2015-12-01 16:00 +0100
      Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-01 17:00 +0100
        Re: [PATCH] staging: unisys: use common return path Ben Romer <benjamin.romer@unisys.com> - 2015-12-01 17:20 +0100
          Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-02 06:10 +0100
        Re: [PATCH] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-02 06:10 +0100
          Re: [PATCH] staging: unisys: use common return path Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-02 07:30 +0100

csiph-web