Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1281447

Re: [PATCH net-next 3/3] vhost_net: basic polling support

From Jason Wang <jasowang@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 3/3] vhost_net: basic polling support
Date 2015-12-02 06:10 +0100
Message-ID <qB7PX-2KY-5@gated-at.bofh.it> (permalink)
References <qyCwW-2WA-7@gated-at.bofh.it> <qyCwX-2WA-27@gated-at.bofh.it> <qAubU-2pN-27@gated-at.bofh.it> <qALw5-5g0-1@gated-at.bofh.it> <qAUpH-2rO-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 12/01/2015 10:43 PM, Michael S. Tsirkin wrote:
> On Tue, Dec 01, 2015 at 01:17:49PM +0800, Jason Wang wrote:
>>
>> On 11/30/2015 06:44 PM, Michael S. Tsirkin wrote:
>>> On Wed, Nov 25, 2015 at 03:11:29PM +0800, Jason Wang wrote:
>>>>> This patch tries to poll for new added tx buffer or socket receive
>>>>> queue for a while at the end of tx/rx processing. The maximum time
>>>>> spent on polling were specified through a new kind of vring ioctl.
>>>>>
>>>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>> One further enhancement would be to actually poll
>>> the underlying device. This should be reasonably
>>> straight-forward with macvtap (especially in the
>>> passthrough mode).
>>>
>>>
>> Yes, it is. I have some patches to do this by replacing
>> skb_queue_empty() with sk_busy_loop() but for tap.
> We probably don't want to do this unconditionally, though.
>
>> Tests does not show
>> any improvement but some regression.
> Did you add code to call sk_mark_napi_id on tap then?
> sk_busy_loop won't do anything useful without.

Yes I did. Probably something wrong elsewhere.

>
>>  Maybe it's better to test macvtap.
> Same thing ...
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH net-next 3/3] vhost_net: basic polling support Jason Wang <jasowang@redhat.com> - 2015-12-01 06:20 +0100
  Re: [PATCH net-next 3/3] vhost_net: basic polling support "Michael S. Tsirkin" <mst@redhat.com> - 2015-12-01 15:50 +0100
    Re: [PATCH net-next 3/3] vhost_net: basic polling support Jason Wang <jasowang@redhat.com> - 2015-12-02 06:10 +0100
      Re: [PATCH net-next 3/3] vhost_net: basic polling support "Michael S. Tsirkin" <mst@redhat.com> - 2015-12-02 13:40 +0100
        Re: [PATCH net-next 3/3] vhost_net: basic polling support Jason Wang <jasowang@redhat.com> - 2015-12-04 03:30 +0100

csiph-web