Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support

From	Gregory CLEMENT <gregory.clement@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support
Date	2015-11-30 17:50 +0100
Message-ID	<qAzOh-66r-7@gated-at.bofh.it> (permalink)
References	<qyJI6-7CO-5@gated-at.bofh.it> <qyJI6-7CO-11@gated-at.bofh.it> <qzQRc-2PH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Marcin,
 
 On sam., nov. 28 2015, Marcin Wojtas <mw@semihalf.com> wrote:

> Hi Gregory,
>
>> +
>> +       /* update unicast mapping */
>> +       mvneta_set_rx_mode(pp->dev);
>
> I know it may be an ultimate level of nitpicking, but can you start a
> comment with capital letter?:)

If I got other review, then I can fix it in the next version. But if you
have a look on the otehr commet not all of them start by capital letter.

Thanks,

Greogry

>
> Best regards,
> Marcin

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-25 16:00 +0100
  Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-11-25 18:00 +0100
    Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-25 18:10 +0100
  Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Marcin Wojtas <mw@semihalf.com> - 2015-11-28 17:50 +0100
    Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-30 17:50 +0100

csiph-web