Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280094

Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC

Show all headers | View raw

On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote:
> The error message was:
> 
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00,  0,  0
> 
> The new error message:
> 
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index b7c038c75684..7d2b96d5f350 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct
> spi_nor *nor) return &spi_nor_ids[tmp];
>  		}
>  	}
> -	dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
> +	dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n",

You can change it to %02x to make it consistent, no ? What do you think ?

>  		id[0], id[1], id[2]);
>  	return ERR_PTR(-ENODEV);
>  }

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi/nor: Fix error message with unrecognized JEDEC Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2015-11-30 16:30 +0100
  Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC Marek Vasut <marex@denx.de> - 2015-11-30 17:50 +0100
    Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2015-11-30 20:50 +0100

csiph-web