Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Gregory CLEMENT <gregory.clement@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support
Date	Mon, 30 Nov 2015 17:50:01 +0100
Message-ID	<qAzOh-66r-7@gated-at.bofh.it> (permalink)
References	<qyJI6-7CO-5@gated-at.bofh.it> <qyJI6-7CO-11@gated-at.bofh.it> <qzQRc-2PH-1@gated-at.bofh.it>
X-Original-To	Marcin Wojtas <mw@semihalf.com>
User-Agent	Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	"David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Ezequiel Garcia <ezequiel.garcia@free-electrons.com>, "linux-arm-kernel\@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Lior Amsalem <alior@marvell.com>, Nadav Haklai <nadavh@marvell.com>, Simon Guinot <simon.guinot@sequanux.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, Boris BREZILLON <boris.brezillon@free-electrons.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, Willy Tarreau <w@1wt.eu>
X-Original-Date	Mon, 30 Nov 2015 17:40:05 +0100
X-Original-Message-ID	<87poyr4f16.fsf@free-electrons.com>
X-Original-References	<1448463243-21057-1-git-send-email-gregory.clement@free-electrons.com> <1448463243-21057-4-git-send-email-gregory.clement@free-electrons.com> <CAPv3WKfEJGAHgDvfyeHKZaiJqbsyrV+uKM+E3enbNLVznLY6zA@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1280095

Show key headers only | View raw

Hi Marcin,
 
 On sam., nov. 28 2015, Marcin Wojtas <mw@semihalf.com> wrote:

> Hi Gregory,
>
>> +
>> +       /* update unicast mapping */
>> +       mvneta_set_rx_mode(pp->dev);
>
> I know it may be an ultimate level of nitpicking, but can you start a
> comment with capital letter?:)

If I got other review, then I can fix it in the next version. But if you
have a look on the otehr commet not all of them start by capital letter.

Thanks,

Greogry

>
> Best regards,
> Marcin

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-25 16:00 +0100
  Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-11-25 18:00 +0100
    Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-25 18:10 +0100
  Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Marcin Wojtas <mw@semihalf.com> - 2015-11-28 17:50 +0100
    Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-30 17:50 +0100

csiph-web