Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons
Date	2015-09-12 08:30 +0200
Message-ID	<q7MtY-ND-5@gated-at.bofh.it> (permalink)
References	<q7M0W-8sn-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2015-09-12 at 11:19 +0530, Shraddha Barke wrote:
> This patch removes comparisons to true/false values on bool variables.
> Fixed using Coccinelle

Please do the "== false" and "!= false" cases at the same time
or in another patch.

> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
> @@ -409,7 +409,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l
>  
>  		arg |= BIT(7);/* support entry 2~31 */
>  
> -		if (shortGIrate == true)
> +		if (shortGIrate)
>  			arg |= BIT(5);
>  
>  		tx_ra_bitmap |= ((raid<<28)&0xf0000000);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
  [PATCH 3/4] Staging: rtl8712: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
  [PATCH 2/4] Staging: rtl8188eu: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
  [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
    Re: [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons Julia Lawall <julia.lawall@lip6.fr> - 2015-09-12 08:20 +0200
  Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need  comparisons Joe Perches <joe@perches.com> - 2015-09-12 08:30 +0200

csiph-web