Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223323

Re: [PATCH] ipvs:Fix locking requirements in the function ip_vs_unlink_service

Show all headers | View raw

	Hello,

On Sat, 12 Sep 2015, Nicholas Krause wrote:

> This fixes locking requirements in the function ip_vs_unlink_service
> to properly use bottom half spinlocking around the call to the function
> __ip_vs_del_service  in order to meet the locking that this paricular
> function requires as stated in it's comments related to locking.

> +	spin_lock_bh(&svc->sched_lock);
>  	__ip_vs_del_service(svc, cleanup);
> +	spin_unlock_bh(&svc->sched_lock);

	BH locking is not needed anymore. Also, sched_lock is
used by schedulers to protect only access to svc->sched_data
fields.

	It seems the comment is outdated after
commit ceec4c381681 ("ipvs: convert services to rcu").

Regards

--
Julian Anastasov <ja@ssi.bg>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ipvs:Fix locking requirements in the function  ip_vs_unlink_service Julian Anastasov <ja@ssi.bg> - 2015-09-12 08:30 +0200
  Re: [PATCH] ipvs:Fix locking requirements in the function  ip_vs_unlink_service Julian Anastasov <ja@ssi.bg> - 2015-09-12 20:40 +0200

csiph-web