Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223321

Re: [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons

Show all headers | View raw

On Sat, 12 Sep 2015, Shraddha Barke wrote:

> This patch removes comparisons to true/false values on bool variables.
> Fix made using Coccinelle
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/vt6656/wcmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
> index 3cbf479..ab7401e 100644
> --- a/drivers/staging/vt6656/wcmd.c
> +++ b/drivers/staging/vt6656/wcmd.c
> @@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command)
>  	ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
>  	priv->free_cmd_queue--;
>  
> -	if (priv->cmd_running == false)
> +	if (priv->cmd_running)

You turned it into a test for true.  It seems strange that this would 
happen if you used a rule.

julia

>  		vnt_cmd_complete(priv);
>  
>  	return true;
> -- 
> 2.1.4
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
  [PATCH 3/4] Staging: rtl8712: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
  [PATCH 2/4] Staging: rtl8188eu: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
  [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-12 08:00 +0200
    Re: [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons Julia Lawall <julia.lawall@lip6.fr> - 2015-09-12 08:20 +0200
  Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need  comparisons Joe Perches <joe@perches.com> - 2015-09-12 08:30 +0200

csiph-web