Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1161113

Re: [PATCH] crush:Make the function crush_ln static

From Ilya Dryomov <idryomov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] crush:Make the function crush_ln static
Date 2015-06-09 10:10 +0200
Message-ID <pzmLF-Be-17@gated-at.bofh.it> (permalink)
References <pzmLF-Be-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This makes the function, crush_ln static now due to having
> only one caller in its own definition and declaration file
> of mapper.c
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  net/ceph/crush/mapper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
> index 5b47736..86778d4 100644
> --- a/net/ceph/crush/mapper.c
> +++ b/net/ceph/crush/mapper.c
> @@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw *bucket,
>  }
>
>  // compute 2^44*log2(input+1)
> -uint64_t crush_ln(unsigned xin)
> +static uint64_t crush_ln(unsigned xin)
>  {
>      unsigned x=xin, x1;
>      int iexpon, index1, index2;

This is tied up with a bunch of style cleanups, I'll apply it after
they are sorted out.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] crush:Make the function crush_ln static Ilya Dryomov <idryomov@gmail.com> - 2015-06-09 10:10 +0200
  Re: [PATCH] crush:Make the function crush_ln static Ilya Dryomov <idryomov@gmail.com> - 2015-06-16 20:00 +0200

csiph-web