Path: csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: Ilya Dryomov Newsgroups: linux.kernel Subject: Re: [PATCH] crush:Make the function crush_ln static Date: Tue, 09 Jun 2015 10:10:03 +0200 Message-ID: References: X-Original-To: Nicholas Krause Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=oNVVb5k1dN2QZr+pEULLn+MfMbZc8CDCC16TVZFH/HE=; b=kwKUfm+eAZQ3KEvLfLZL+w5HJjGprD8oxEdnR1r4YNgxjzknHWBBf8uocQBhO3jhEw HRMFGCxysFtETIgKO++jkaj69YMP2X/f4VvxvMwzHL7GcJOVemV1LpnbpKLq8St+rCMR BCXGoq6qN9lGDSC86SwXFGBybpz/WIiCzpAlL5zvht7FQi4KuOsZQtQxNT8W6PTbIdam gnC9HRe6LvNbEeJq/UWOVVKa5wCkX314pT/6V/5+npzC38dXmZZF80yGiQ9lrB/myYp9 wknLmTSx14FbCQ27T2BwxQ/D4Vqb93MY//1SVRNnnGOnd4N5m9zXSNsliDE/ad5ibd5g 0GmQ== MIME-Version: 1.0 X-Received: by 10.194.222.137 with SMTP id qm9mr40177518wjc.43.1433836810979; Tue, 09 Jun 2015 01:00:10 -0700 (PDT) Content-Type: text/plain; charset=UTF-8 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 35 Organization: linux.* mail to news gateway X-Original-Cc: "Yan, Zheng" , Sage Weil , "David S. Miller" , Ceph Development , netdev , "linux-kernel@vger.kernel.org" X-Original-Date: Tue, 9 Jun 2015 11:00:10 +0300 X-Original-Message-ID: X-Original-References: <1433803863-9241-1-git-send-email-xerofoify@gmail.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: aioe.org linux.kernel:1161113 On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote: > This makes the function, crush_ln static now due to having > only one caller in its own definition and declaration file > of mapper.c > > Signed-off-by: Nicholas Krause > --- > net/ceph/crush/mapper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c > index 5b47736..86778d4 100644 > --- a/net/ceph/crush/mapper.c > +++ b/net/ceph/crush/mapper.c > @@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw *bucket, > } > > // compute 2^44*log2(input+1) > -uint64_t crush_ln(unsigned xin) > +static uint64_t crush_ln(unsigned xin) > { > unsigned x=xin, x1; > int iexpon, index1, index2; This is tied up with a bunch of style cleanups, I'll apply it after they are sorted out. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/