Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1161113 > unrolled thread

Re: [PATCH] crush:Make the function crush_ln static

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] crush:Make the function crush_ln static Ilya Dryomov <idryomov@gmail.com> - 2015-06-09 10:10 +0200
    Re: [PATCH] crush:Make the function crush_ln static Ilya Dryomov <idryomov@gmail.com> - 2015-06-16 20:00 +0200

#1161113 — Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This makes the function, crush_ln static now due to having
> only one caller in its own definition and declaration file
> of mapper.c
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  net/ceph/crush/mapper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
> index 5b47736..86778d4 100644
> --- a/net/ceph/crush/mapper.c
> +++ b/net/ceph/crush/mapper.c
> @@ -239,7 +239,7 @@ static int bucket_straw_choose(struct crush_bucket_straw *bucket,
>  }
>
>  // compute 2^44*log2(input+1)
> -uint64_t crush_ln(unsigned xin)
> +static uint64_t crush_ln(unsigned xin)
>  {
>      unsigned x=xin, x1;
>      int iexpon, index1, index2;

This is tied up with a bunch of style cleanups, I'll apply it after
they are sorted out.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1166294

On Tue, Jun 16, 2015 at 8:22 PM, nick <xerofoify@gmail.com> wrote:
>
>
> On 2015-06-16 01:16 PM, Ilya Dryomov wrote:
>> On Tue, Jun 16, 2015 at 8:07 PM, nick <xerofoify@gmail.com> wrote:
>>>
>>>
>>> On 2015-06-16 12:47 PM, Ilya Dryomov wrote:
>>>> On Tue, Jun 16, 2015 at 7:18 PM, nick <xerofoify@gmail.com> wrote:
>>>>> Ilya,
>>>>> That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups/
>>>>> fixes and need help getting them merged. Should I just resend them or wait until the end of this merge window.
>>>>
>>>> Are all of those ceph patches?
>>>>
>>>> Thanks,
>>>>
>>>>                 Ilya
>>>>
>>> Ilya,
>>> Sorry for the second email but two of them are. I just checked, would you like me to resend
>>> these two patches.
>>
>> No need to resend, just point them out in a reply.
>>
>> Thanks,
>>
>>                 Ilya
>>
> The two patches have these subject headers:
> ceph:Remove the unused marco AES_KEY_SIZE
> ceph:Make the function ceph_monmap_contains bool
> If you can't find them I will resend them.

I can't - looks like ceph-devel wasn't CC'ed.  Please resend.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web