Groups > linux.kernel > #1208090

Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()
Date	2015-08-15 16:10 +0200
Message-ID	<pXKjL-3FW-9@gated-at.bofh.it> (permalink)
References	<pXlY5-1B0-5@gated-at.bofh.it> <pXzeG-3OQ-19@gated-at.bofh.it> <pXAaK-5CB-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, Aug 15, 2015 at 08:41:49AM +0530, Viresh Kumar wrote:

> Hopefully below version looks better ?

Please don't bury patches at the end of replies to messages in the
middle of threads, send them in a form where they can be applied
directly.

> Subject: [PATCH] regulator: core: Define regulator_set_voltage_triplet()
> 
> The OPP (Operating performance points) v2 bindings allows regulator
> voltage to be supplied as a triplet of <target min max> voltages.
> 
> Add regulator_set_voltage_triplet() API in regulator core to support
> that.

This should explain why this is useful at a regulator API level, not
explain that some user decided to do something.

> +static inline int regulator_set_voltage_triplet(struct regulator *regulator,
> +						int min_uV, int target_uV,
> +						int max_uV)
> +{
> +	if (!regulator_set_voltage(regulator, target_uV, max_uV))

Make this a check for == 0 which is what you mean here, this isn't a
boolean function.

Thread

[PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-14 14:10 +0200
  Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Mark Brown <broonie@kernel.org> - 2015-08-15 04:20 +0200
    Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-15 05:20 +0200
      Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Mark Brown <broonie@kernel.org> - 2015-08-15 16:10 +0200
        Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-17 04:20 +0200

csiph-web