Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1208090

Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()
Date Sat, 15 Aug 2015 16:10:01 +0200
Message-ID <pXKjL-3FW-9@gated-at.bofh.it> (permalink)
References <pXlY5-1B0-5@gated-at.bofh.it> <pXzeG-3OQ-19@gated-at.bofh.it> <pXAaK-5CB-1@gated-at.bofh.it>
X-Original-To Viresh Kumar <viresh.kumar@linaro.org>
MIME-Version 1.0
Content-Type multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aa1lHgJENwUhkhu9"
Content-Disposition inline
X-Cookie if it GLISTENS, gobble it!!
User-Agent Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP 70.98.210.100
X-Sa-Exim-Mail-From broonie@sirena.org.uk
X-Sa-Exim-Version 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned Yes (on mezzanine.sirena.org.uk)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 57
Organization linux.* mail to news gateway
X-Original-Cc linaro-kernel@lists.linaro.org, sboyd@codeaurora.org, nm@ti.com, Liam Girdwood <lgirdwood@gmail.com>, "open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" <linux-kernel@vger.kernel.org>
X-Original-Date Sat, 15 Aug 2015 07:08:05 -0700
X-Original-Message-ID <20150815140805.GB10748@sirena.org.uk>
X-Original-References <28971ff9b110d18970fcc6291531f617cda18230.1439553400.git.viresh.kumar@linaro.org> <20150814162506.GV10748@sirena.org.uk> <20150815031149.GD1162@linux>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1208090

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Sat, Aug 15, 2015 at 08:41:49AM +0530, Viresh Kumar wrote:

> Hopefully below version looks better ?

Please don't bury patches at the end of replies to messages in the
middle of threads, send them in a form where they can be applied
directly.

> Subject: [PATCH] regulator: core: Define regulator_set_voltage_triplet()
> 
> The OPP (Operating performance points) v2 bindings allows regulator
> voltage to be supplied as a triplet of <target min max> voltages.
> 
> Add regulator_set_voltage_triplet() API in regulator core to support
> that.

This should explain why this is useful at a regulator API level, not
explain that some user decided to do something.

> +static inline int regulator_set_voltage_triplet(struct regulator *regulator,
> +						int min_uV, int target_uV,
> +						int max_uV)
> +{
> +	if (!regulator_set_voltage(regulator, target_uV, max_uV))

Make this a check for == 0 which is what you mean here, this isn't a
boolean function.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-14 14:10 +0200
  Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Mark Brown <broonie@kernel.org> - 2015-08-15 04:20 +0200
    Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-15 05:20 +0200
      Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Mark Brown <broonie@kernel.org> - 2015-08-15 16:10 +0200
        Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-17 04:20 +0200

csiph-web