Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208308

Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()

Show all headers | View raw

On 15-08-15, 07:08, Mark Brown wrote:
> On Sat, Aug 15, 2015 at 08:41:49AM +0530, Viresh Kumar wrote:
> 
> > Hopefully below version looks better ?
> 
> Please don't bury patches at the end of replies to messages in the
> middle of threads, send them in a form where they can be applied
> directly.

Okay. I thought its fine to send patches like this and this can be
applied directly with the --scissors option to git am or with
mailinfo.scissors option set in configuration file.

But will surely send patches separately to you.

> > Subject: [PATCH] regulator: core: Define regulator_set_voltage_triplet()
> > 
> > The OPP (Operating performance points) v2 bindings allows regulator
> > voltage to be supplied as a triplet of <target min max> voltages.
> > 
> > Add regulator_set_voltage_triplet() API in regulator core to support
> > that.
> 
> This should explain why this is useful at a regulator API level, not
> explain that some user decided to do something.

Okay.

> > +static inline int regulator_set_voltage_triplet(struct regulator *regulator,
> > +						int min_uV, int target_uV,
> > +						int max_uV)
> > +{
> > +	if (!regulator_set_voltage(regulator, target_uV, max_uV))
> 
> Make this a check for == 0 which is what you mean here, this isn't a
> boolean function.

Okay.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-14 14:10 +0200
  Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Mark Brown <broonie@kernel.org> - 2015-08-15 04:20 +0200
    Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-15 05:20 +0200
      Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Mark Brown <broonie@kernel.org> - 2015-08-15 16:10 +0200
        Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-17 04:20 +0200

csiph-web