Groups > linux.kernel > #1190021

Re: [PATCH 2/3] perpuc: check pcpu_first_chunk and pcpu_reserved_chunk to avoid handling them twice

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] perpuc: check pcpu_first_chunk and pcpu_reserved_chunk to avoid handling them twice
Date	2015-07-22 16:40 +0200
Message-ID	<pP3lE-19S-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <pOkHU-4n9-19@gated-at.bofh.it> <pOHEv-3Pl-29@gated-at.bofh.it> <pOPLI-76A-21@gated-at.bofh.it> <pP2IW-bi-15@gated-at.bofh.it> <pP3bY-YT-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 22, 2015 at 10:29:00PM +0800, Baoquan He wrote:
> > > So if no reserved_size dyn_size is assigned to zero, and is checked to
> > > see if dchunk need be created in below code:
> > 
> > Hmmm... but then pcpu_reserved_chunk is NULL so there still is no
> > duplicate on the list, no?
> 
> Yes, you are quite right. I was mistaken. So NACK this patch.

But, yeah, it'd be great if we can add a WARN_ON() to ensure that this
really doesn't happen along with some comments.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] perpuc: check pcpu_first_chunk and  pcpu_reserved_chunk to avoid handling them twice Tejun Heo <tj@kernel.org> - 2015-07-22 16:00 +0200
  Re: [PATCH 2/3] perpuc: check pcpu_first_chunk and  pcpu_reserved_chunk to avoid handling them twice Baoquan He <bhe@redhat.com> - 2015-07-22 16:30 +0200
    Re: [PATCH 2/3] perpuc: check pcpu_first_chunk and  pcpu_reserved_chunk to avoid handling them twice Tejun Heo <tj@kernel.org> - 2015-07-22 16:40 +0200

csiph-web