Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1180743
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Linux 4.2-rc1 |
| Date | 2015-07-09 15:20 +0200 |
| Message-ID | <pKjU6-DN-7@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <pK0y6-53H-5@gated-at.bofh.it> <pK1aO-5wA-9@gated-at.bofh.it> <pK1kt-5zO-1@gated-at.bofh.it> <pK8lY-1Lr-13@gated-at.bofh.it> <pKaxr-3kQ-3@gated-at.bofh.it> |
| Organization | Samsung Open Source Group |
On 07/08/2015 09:17 PM, Linus Torvalds wrote: > On Wed, Jul 8, 2015 at 5:58 PM, Ming Lei <ming.lei@canonical.com> wrote: >> On Thu, Jul 9, 2015 at 1:29 AM, Linus Torvalds >> <torvalds@linux-foundation.org> wrote: >>> Also, it looks like you need to hold the "fw_lock" to even look at >>> that pointer, since the buffer can get reallocated etc. >> >> Yes, the above code with holding 'fw_lock' is right fix for the issue since >> sysfs read can happen anytime, and there is one race between firmware >> request abort and reading uevent of sysfs. > > So if fw_priv->buf is NULL, what should we do? > > Should we skip the TIMEOUT= and ASYNC= fields too? > > Something like the attached, perhaps? > > Shuah, how reproducible is this? Does this (completely untested) patch > make any difference? > Happened both times I booted 4.2-rc1 up, so I would say 100% so far. I will test with your patch and report results. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: Linux 4.2-rc1 Ming Lei <ming.lei@canonical.com> - 2015-07-09 03:00 +0200
Re: Linux 4.2-rc1 Shuah Khan <shuahkh@osg.samsung.com> - 2015-07-09 15:20 +0200
Re: Linux 4.2-rc1 Shuah Khan <shuahkh@osg.samsung.com> - 2015-07-10 19:00 +0200
Re: Linux 4.2-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2015-07-10 19:20 +0200
Re: Linux 4.2-rc1 Ming Lei <ming.lei@canonical.com> - 2015-07-11 00:40 +0200
csiph-web