Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1181972

Re: Linux 4.2-rc1

Show all headers | View raw

On Sat, Jul 11, 2015 at 5:47 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> But my patch (which is committed now) solves it all for you?
>
> I'm going to just assume it's timing, and there is no major real reason why
> it started triggering just now...

Now I see it, the issue is triggered when firmware request is
timed out, and Shuah's reported should be caused by the following
commit 0cb64249(firmware_loader: abort request if wait_for_completion
is interrupted).

But your patch is correct for this issue too.

Thanks,
Ming

>
>      Linus
>
> On Jul 10, 2015 2:33 PM, "Shuah Khan" <shuahkh@osg.samsung.com> wrote:
>>
>> On 07/10/2015 11:11 AM, Linus Torvalds wrote:
>> > On Fri, Jul 10, 2015 at 9:58 AM, Shuah Khan <shuahkh@osg.samsung.com>
>> > wrote:
>> >>
>> >> I am not sure why this patch would cause the problem I am seeing.
>> >> This patch itself looks like a cleanup type patch and doesn't
>> >> really fix a bug. I am building with this patch reverted at the
>> >> moment to confirm.
>> >
>> > Smells to me like it's just a timing issue, and that mayeb the bisect
>> > failed because it's not 100% repeatable. Or maybe it *was* 100%
>> > repeatable, but simply because that commit changed the timing of the
>> > bootup scripts etc.
>> >
>> > But yes, trying it with the revert in place is a good idea just to
>> > make sure. And perhaps checking that kernel more than a few times to
>> > verify just how repeatable it is.
>> >
>>
>> Quick update. Reverting didn't help. I think I mentioned I am seeing
>> hangs during poweroff and reboot. I am seeing hangs during boot as well.
>> I think there is a timing problem that manifests into the following
>> 3 variations:
>>
>> 1. NULL pointer dereference alert, boots fine and runs fine - hangs
>>    during poweroff and reboot
>> 2. Hangs during boot. When booted in recovery, it runs into repeated
>>    errors which looks very much like the same call trace I see in the
>>    alert.
>>
>> Please see attached images. These two are rolling failures repeated
>> during udev initialization. It is related to firmware loading it looks
>> like.
>>
>> thanks,
>> -- Shuah
>>
>> --
>> Shuah Khan
>> Sr. Linux Kernel Developer
>> Open Source Innovation Group
>> Samsung Research America (Silicon Valley)
>> shuahkh@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Linux 4.2-rc1 Ming Lei <ming.lei@canonical.com> - 2015-07-09 03:00 +0200
  Re: Linux 4.2-rc1 Shuah Khan <shuahkh@osg.samsung.com> - 2015-07-09 15:20 +0200
    Re: Linux 4.2-rc1 Shuah Khan <shuahkh@osg.samsung.com> - 2015-07-10 19:00 +0200
      Re: Linux 4.2-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2015-07-10 19:20 +0200
        Re: Linux 4.2-rc1 Ming Lei <ming.lei@canonical.com> - 2015-07-11 00:40 +0200

csiph-web