Re: Linux 4.2-rc1

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: Linux 4.2-rc1
Date	Thu, 09 Jul 2015 15:20:02 +0200
Message-ID	<pKjU6-DN-7@gated-at.bofh.it> (permalink)
References	<pIYI1-7ia-3@gated-at.bofh.it> <pK0y6-53H-5@gated-at.bofh.it> <pK1aO-5wA-9@gated-at.bofh.it> <pK1kt-5zO-1@gated-at.bofh.it> <pK8lY-1Lr-13@gated-at.bofh.it> <pKaxr-3kQ-3@gated-at.bofh.it>
X-Original-To	Linus Torvalds <torvalds@linux-foundation.org>, Ming Lei <ming.lei@canonical.com>
Organization	Samsung Open Source Group
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
X-Original-Cc	Shuah Khan <shuahkhan@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 09 Jul 2015 07:10:09 -0600
X-Original-Message-ID	<559E72B1.2050903@osg.samsung.com>
X-Original-References	<CA+55aFxmm7THBsCK62esr=JCcHpn6nmReGKqPp0inUrhbkveuA@mail.gmail.com> <CAKocOOM0-uce9kUzprCW9M48_G2OTV-eWgPe4euht2qY8FdA3A@mail.gmail.com> <CA+55aFy-iZ2g8xKZW---LgUHaVMbqLZ_oadw=Vbg0g78dfH9PA@mail.gmail.com> <CA+55aFyYFhkupwb0tVLCDWQs9H1DX0kXZZkCwax_xUOUMfDgxA@mail.gmail.com> <CACVXFVMc0YNm=GAGN7XWv-47MsT+jK6HFsMERbDgW2QM0wMsSQ@mail.gmail.com> <CA+55aFxc6Dg40L1CvNkxWopaO1_WQUu9L5ncv=8VgsGgB8ZgFQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1180743

Show key headers only | View raw

On 07/08/2015 09:17 PM, Linus Torvalds wrote:
> On Wed, Jul 8, 2015 at 5:58 PM, Ming Lei <ming.lei@canonical.com> wrote:
>> On Thu, Jul 9, 2015 at 1:29 AM, Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>>> Also, it looks like you need to hold the "fw_lock" to even look at
>>> that pointer, since the buffer can get reallocated etc.
>>
>> Yes, the above code with holding 'fw_lock' is right fix for the issue since
>> sysfs read can happen anytime, and there is one race between firmware
>> request abort and reading uevent of sysfs.
> 
> So if fw_priv->buf is NULL, what should we do?
> 
> Should we skip the TIMEOUT= and ASYNC= fields too?
> 
> Something like the attached, perhaps?
> 
> Shuah, how reproducible is this? Does this (completely untested) patch
> make any difference?
> 

Happened both times I booted 4.2-rc1 up, so I would say 100% so far.
I will test with your patch and report results.

-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: Linux 4.2-rc1 Ming Lei <ming.lei@canonical.com> - 2015-07-09 03:00 +0200
  Re: Linux 4.2-rc1 Shuah Khan <shuahkh@osg.samsung.com> - 2015-07-09 15:20 +0200
    Re: Linux 4.2-rc1 Shuah Khan <shuahkh@osg.samsung.com> - 2015-07-10 19:00 +0200
      Re: Linux 4.2-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2015-07-10 19:20 +0200
        Re: Linux 4.2-rc1 Ming Lei <ming.lei@canonical.com> - 2015-07-11 00:40 +0200

csiph-web