Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

From	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices
Date	2015-07-08 14:50 +0200
Message-ID	<pJWXx-2KA-17@gated-at.bofh.it> (permalink)
References	<pJbvz-6OB-1@gated-at.bofh.it> <pJbFh-6Su-37@gated-at.bofh.it> <pJWNS-2GX-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Chunyan Zhang <zhang.lyra@gmail.com> writes:

>> +int __init stp_configfs_init(void)
>> +{
>> +       int err;
>> +
>> +       config_group_init(&stp_policy_subsys.su_group);
>> +       mutex_init(&stp_policy_subsys.su_mutex);
>> +       err = configfs_register_subsystem(&stp_policy_subsys);
>> +
>> +       return err;
>
> One small suggestion, is it better like this:
> return configfs_register_subsystem(&stp_policy_subsys);
> As such, we don't need the local variable "err" any more.

You are right, err doesn't serve any purpose here.

Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-07-08 14:50 +0200

csiph-web