Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1179749
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices |
| Date | Wed, 08 Jul 2015 14:50:03 +0200 |
| Message-ID | <pJWXx-2KA-17@gated-at.bofh.it> (permalink) |
| References | <pJbvz-6OB-1@gated-at.bofh.it> <pJbFh-6Su-37@gated-at.bofh.it> <pJWNS-2GX-29@gated-at.bofh.it> |
| X-Original-To | Chunyan Zhang <zhang.lyra@gmail.com> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.15,431,1432623600"; d="scan'208";a="758323152" |
| User-Agent | Notmuch/0.20.1 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | text/plain |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 26 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>, mathieu.poirier@linaro.org, peter.lachner@intel.com, norbert.schulz@intel.com, keven.boell@intel.com, yann.fouassier@intel.com, laurent.fert@intel.com, "linux-api\@vger.kernel.org" <linux-api@vger.kernel.org> |
| X-Original-Date | Wed, 08 Jul 2015 15:49:03 +0300 |
| X-Original-Message-ID | <87pp42n7b4.fsf@ashishki-desk.ger.corp.intel.com> |
| X-Original-References | <1436177344-16751-1-git-send-email-alexander.shishkin@linux.intel.com> <1436177344-16751-2-git-send-email-alexander.shishkin@linux.intel.com> <CAAfSe-vDUdA+kY04-u-SXT-pdy_hn1hY1yG6-e-k_tbLsFzjKQ@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | aioe.org linux.kernel:1179749 |
Show key headers only | View raw
Chunyan Zhang <zhang.lyra@gmail.com> writes:
>> +int __init stp_configfs_init(void)
>> +{
>> + int err;
>> +
>> + config_group_init(&stp_policy_subsys.su_group);
>> + mutex_init(&stp_policy_subsys.su_mutex);
>> + err = configfs_register_subsystem(&stp_policy_subsys);
>> +
>> + return err;
>
> One small suggestion, is it better like this:
> return configfs_register_subsystem(&stp_policy_subsys);
> As such, we don't need the local variable "err" any more.
You are right, err doesn't serve any purpose here.
Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-07-08 14:50 +0200
csiph-web