Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1179749 > unrolled thread

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-07-08 14:50 +0200

#1179749 — Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

Chunyan Zhang <zhang.lyra@gmail.com> writes:

>> +int __init stp_configfs_init(void)
>> +{
>> +       int err;
>> +
>> +       config_group_init(&stp_policy_subsys.su_group);
>> +       mutex_init(&stp_policy_subsys.su_mutex);
>> +       err = configfs_register_subsystem(&stp_policy_subsys);
>> +
>> +       return err;
>
> One small suggestion, is it better like this:
> return configfs_register_subsystem(&stp_policy_subsys);
> As such, we don't need the local variable "err" any more.

You are right, err doesn't serve any purpose here.

Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web