Re: [PATCH 1/1] mfd: remove unnecessary check

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] mfd: remove unnecessary check
Date	2015-07-02 02:20 +0200
Message-ID	<pHAop-3OA-3@gated-at.bofh.it> (permalink)
References	<pH2G6-1wN-5@gated-at.bofh.it> <pHkWm-2ey-9@gated-at.bofh.it> <pHkWm-2ey-7@gated-at.bofh.it> <pHl63-2i0-35@gated-at.bofh.it> <pHqS5-6ae-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2015-07-01 23:08 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote:
>
>> 2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
>> > On Wed, 01 Jul 2015, Lee Jones wrote:
>> >> On Tue, 30 Jun 2015, Maninder Singh wrote:
>> >>
>> >> >  o Making pdata NULL check to (!pdata) as coding statndard
>> >> >     and all other checks in file.
>> >> >  o Removing redundant check of pdata, because we already
>> >> >     check for pdata, and also derefernced before this check
>> >> >
>> >> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> >> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> >> > ---
>> >> >  drivers/mfd/t7l66xb.c |    4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> Applied, with a properly formatted subject line.
>> >
>> > Should have probably been more forthcomming with some advice.
>> >
>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>> > the accepted format is.
>>
>> ... and a spell-check could be useful as well :). The reviewed-by tag
>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>> so I think it should be dropped.
>
> Fair points.  Patch dropped.

I meant the reviewed-by tag should be dropped :) .

So now... Maninder Singh, could you resent the patch with this minor
issues fixed?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] mfd: remove unnecessary check Lee Jones <lee.jones@linaro.org> - 2015-07-01 09:50 +0200
  Re: [PATCH 1/1] mfd: remove unnecessary check Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-01 10:00 +0200
    Re: [PATCH 1/1] mfd: remove unnecessary check Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-02 02:20 +0200

csiph-web